D28195: Avoid double fetch and temporary hex encoding for NTFS attributes

Stefan BrĂ¼ns noreply at phabricator.kde.org
Sun Mar 22 12:35:53 GMT 2020


bruns added inline comments.

INLINE COMMENTS

> dfaure wrote in file_unix.cpp:533
> Given that the value of `n` isn't used, any reason why this doesn't iterate upwards instead, as the old code was doing? I just find it more usual and readable.

To make sure n and length have the same type. Otherwise an int and a ssize_t, or whatever getxattr* return, are compared.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D28195

To: bruns, #dolphin, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20200322/5afefedb/attachment.htm>


More information about the kfm-devel mailing list