D8208: Add Duplicate feature

[Elvis Angelaccio]

elvisangelaccio requested changes to this revision.
elvisangelaccio added a comment.
This revision now requires changes to proceed.


  I'd say it's time to merge this patch since the 20.04 feature freeze is close.
  
  Just a minor thing (see inline) and then you can push it.

INLINE COMMENTS

> dolphinview.cpp:752-757
> +    // FIXME: forceUrlsSelection seems to be async; if we initiate a rename
> +    // operation right after this, nothing is selected, so it fails
> +    if (selectedItems().count() == 1) {
> +        renameSelectedItems();
> +    }
> +}

Since this doesn't work, I'd just remove it.

(I still think that we don't need to trigger renaming in the first place).

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D8208

To: ngraham, #dolphin, #kde_applications, elvisangelaccio, dfaure, broulik, davidedmundson
Cc: jacobtaylor, fvogt, mthw, kfm-devel, meven, markg, fazevedo, cfeck, #dolphin, pberestov, iasensio, fprice, MrPepe, fbampaloukas, alexde, Codezela, feverfew, spoorun, navarromorales, firef, ngraham, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20200315/6be72e9c/attachment.htm>