D28014: smb: do not double finish

Harald Sitter noreply at phabricator.kde.org
Thu Mar 12 13:07:33 GMT 2020


sitter created this revision.
sitter added a reviewer: ngraham.
Herald added projects: Dolphin, Frameworks.
Herald added subscribers: kfm-devel, kde-frameworks-devel.
sitter requested review of this revision.

REVISION SUMMARY
  finish() must not be called twice yet previously the case branches
  would call it but then there'd also be a global finished after the switch.
  remove the cases' finished().
  
  this code is, I think, actually not used anywhere so it matters little.

TEST PLAN
  hoping for the best!

REPOSITORY
  R320 KIO Extras

BRANCH
  smb-mount-doublefinish

REVISION DETAIL
  https://phabricator.kde.org/D28014

AFFECTED FILES
  smb/kio_smb_mount.cpp

To: sitter, ngraham
Cc: kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, cblack, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20200312/8712c78f/attachment.htm>


More information about the kfm-devel mailing list