D27976: WIP: UI for maximumFileSize showing correctly, but not working as expected

[Utkarsh Upadhyaya]

pingala added a comment.


  Sorry for the wrong format earlier and thanks, I really appreciate your guidance since I am a newbie.
  
  In D27976#625633 <https://phabricator.kde.org/D27976#625633>, @meven wrote:
  
  > `FEATURE: 331240` should be in the text of the review not as the title, and you can add `FIXED-IN: 20.04` to the commit comment. 
  >  The title should describe what the diff does, not its objective and a be a phrase of some sort.
  >  Ref: https://community.kde.org/Policies/Commit_Policy#Special_keywords_in_GIT_and_SVN_log_messages
  >  And since the patch does not work you can add WIP as title prefix.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D27976

To: pingala, meven, #dolphin
Cc: meven, kfm-devel, pberestov, iasensio, fprice, MrPepe, fbampaloukas, alexde, Codezela, feverfew, spoorun, navarromorales, firef, ngraham, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20200311/4f4015cc/attachment.htm>