D27873: sftp: do not show creation time when we do not know it

[Stefan Brüns]

bruns requested changes to this revision.
bruns added a comment.
This revision now requires changes to proceed.


  Btrfs definitely does support birthtime

INLINE COMMENTS

> kio_sftp.cpp:496
>          entry.fastInsert(KIO::UDSEntry::UDS_MODIFICATION_TIME, sb->mtime);
> -        entry.fastInsert(KIO::UDSEntry::UDS_CREATION_TIME, sb->createtime);
> +        if (sb->createtime != 0) {
> +            // Birth time may be unknown if the underlying file system doesn't

You should check for `SSH_FILEXFER_ATTR_CREATETIME` in the flags field:
https://api.libssh.org/master/group__libssh__sftp.html#gabbfacf308d2116ae09b1ca4f901afe2d

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D27873

To: sitter, ngraham, bruns
Cc: bruns, kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, cblack, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20200305/55d96c48/attachment.htm>