D27810: Correctly disable UDS_ACCESS being set

[David Edmundson]

davidedmundson created this revision.
Herald added projects: Dolphin, Frameworks.
Herald added subscribers: kfm-devel, kde-frameworks-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  718abcb69b78385123dd7a05a66a656af772d581 <https://phabricator.kde.org/R320:718abcb69b78385123dd7a05a66a656af772d581> tries to disable UDS_ACCESS
  being set. See the long comment introduced.
  
  It did this by setting the value to -1 which doesn't achieve that
  result.
  
  -1 is a perfectly valid value that gets send to the client.
  
  Having it set breaks anyone calling udsEntry.numberValue(UDS_ACCESS,
  aLegitimateDefault) getting their default. Something used by kio-fuse.

TEST PLAN
  Used kio-fuse
  Opened a samba file in mplayer
  It opened

REPOSITORY
  R320 KIO Extras

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27810

AFFECTED FILES
  smb/kio_smb_browse.cpp

To: davidedmundson
Cc: kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, cblack, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20200303/d708f665/attachment.htm>