D27801: smb: add a unit test for smburl

Aleix Pol Gonzalez noreply at phabricator.kde.org
Tue Mar 3 14:41:53 GMT 2020


apol added inline comments.

INLINE COMMENTS

> smburl.cpp:67
>  
>  bool SMBUrl::cd(const QString &filedir)
>  {

Can't we then just rename the method to `::cdUp()`?

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D27801

To: sitter, ngraham
Cc: apol, kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, cblack, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20200303/6853542d/attachment.htm>


More information about the kfm-devel mailing list