[dolphin] [Bug 417230] ShowItems does not work if folder is already open

[bugzilla_noreply at kde.org]

https://bugs.kde.org/show_bug.cgi?id=417230

a.saoutkin at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|CONFIRMED                   |RESOLVED
   Version Fixed In|                            |19.12.3
      Latest Commit|                            |https://commits.kde.org/dol
                   |                            |phin/fef7eebc6e3c27e6653bfd
                   |                            |5d8a1abec191dc9835
         Resolution|---                         |FIXED

--- Comment #1 from a.saoutkin at gmail.com ---
Git commit fef7eebc6e3c27e6653bfd5d8a1abec191dc9835 by Alexander Saoutkin.
Committed on 01/03/2020 at 17:17.
Pushed by asaoutkin into branch 'release/19.12'.

Fix files not being highlighted if directory of file is already open

Summary:
In DolphinTabWidget::openFiles it assumes openDirectories will open new tabs,
so it
only marks the URL selection for the newly opened tabs. This assumption is
incorrect
 as Dolphin might reuse tabs when the folder is already open.

Even then, markUrlsAsSelected does nothing when the folder is already opened.
The selection seems to only be used when the folder finishes loading, calls
made after
that only change a variable without updating the actual selection.

A call to DolphinView::updateViewState() is required to restore the intended
behaviour, so long as DolphinView::clearSelection() has been called on the
relevant tab, otherwise updateViewState() is a no-op.
FIXED-IN: 19.12.3

Test Plan:
1. In any application that has an "open containing folder" select that option
2. and then do the same for another file in the same folder

Reviewers: broulik

Reviewed By: broulik

Subscribers: kfm-devel

Tags: #dolphin

Differential Revision: https://phabricator.kde.org/D27389

M  +9    -1    src/dolphintabwidget.cpp
M  +6    -6    src/views/dolphinview.h

https://commits.kde.org/dolphin/fef7eebc6e3c27e6653bfd5d8a1abec191dc9835

-- 
You are receiving this mail because:
You are on the CC list for the bug.