D23168: Use embedded cover in MP4 video files

[Elvis Angelaccio]

elvisangelaccio requested changes to this revision.
elvisangelaccio added a comment.
This revision now requires changes to proceed.


  Please either copy the `FindTaglib.cmake` from ECM master or require KF5 >= 5.72 and don't copy `FindTaglib.cmake` here.

INLINE COMMENTS

> ffmpegthumbnailer.cpp:50
>  {
> +    TagLib::MP4::File f(path.toStdString().c_str(), false);
> +

Please use `toLocal8Bit()` + `data()` instead: https://wiki.qt.io/Technical_FAQ#How_can_I_convert_a_QString_to_char.2A_and_vice_versa.3F

Also, prefer a descriptive variable name.

REVISION DETAIL
  https://phabricator.kde.org/D23168

To: hschaefer, bruns, #dolphin, elvisangelaccio, broulik, ngraham, meven
Cc: ngraham, meven, cfeck, #dolphin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20200621/393861cc/attachment.htm>