[dolphin] [Bug 421973] The selection rectangle in the views mode is smaller than the selected text and makes some later part of the text unreadable.

Elvis Angelaccio bugzilla_noreply at kde.org
Sun Jul 12 22:30:39 BST 2020


https://bugs.kde.org/show_bug.cgi?id=421973

Elvis Angelaccio <elvis.angelaccio at kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Version Fixed In|20.07.80                    |20.07.70
      Latest Commit|https://invent.kde.org/syst |https://invent.kde.org/syst
                   |em/dolphin/commit/76a46fd90 |em/dolphin/commit/bf2eb0d69
                   |94b17eb99e8a42cca8562fdc0b3 |df085b30a7d7a7fad813ad95889
                   |814c                        |3c18

--- Comment #6 from Elvis Angelaccio <elvis.angelaccio at kde.org> ---
Git commit bf2eb0d69df085b30a7d7a7fad813ad958893c18 by Elvis Angelaccio, on
behalf of Ismael Asensio.
Committed on 12/07/2020 at 21:30.
Pushed by elvisangelaccio into branch 'release/20.08'.

Fix selection rect after porting from QFontMetrics::width()

After porting from QFontMetrics::width() to QFontMetrics::boundigRect().width()
in system/dolphin!10 we have a visual bug on selection rects, that can be seen
on details and compact modes.

While from
https://kdepepo.wordpress.com/2019/08/05/about-deprecation-of-qfontmetricswidth/
the use of `boundingRect()` would seem the right option to use (and I struggle
to get the difference between the two methods when applied to a whole string
and not a single char), in this case the `horizontalAdvance()` seems to return
the value we need.
FIXED-IN: 20.07.70

M  +13   -13   src/kitemviews/kstandarditemlistwidget.cpp

https://invent.kde.org/system/dolphin/commit/bf2eb0d69df085b30a7d7a7fad813ad958893c18

-- 
You are receiving this mail because:
You are on the CC list for the bug.



More information about the kfm-devel mailing list