D25741: Add natural sorting and case-insensitive sorting for all role-types

[Nathaniel Graham]

ngraham added a comment.


  This doesn't compile for me:
  
    /home/nate/kde/src/dolphin/src/kitemviews/kfileitemmodel.cpp: In member function ‘int KFileItemModel::sortRoleCompare(const KFileItemModel::ItemData*, const KFileItemModel::ItemData*, const QCollator&) const’:
    /home/nate/kde/src/dolphin/src/kitemviews/kfileitemmodel.cpp:1847:58: error: no matching function for call to ‘KFileItemModel::stringCompare(const QString&, const QString&) const’
     1847 |             result = stringCompare(roleValueA, roleValueB);
          |                                                          ^
  
  I'm on Qt 5.14.

REPOSITORY
  R318 Dolphin

BRANCH
  sort (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25741

To: gvgeo, #dolphin, nicolasfella, meven, elvisangelaccio, ngraham
Cc: cfeck, meven, kfm-devel, pberestov, iasensio, fprice, MrPepe, fbampaloukas, alexde, Codezela, feverfew, spoorun, navarromorales, firef, ngraham, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20200127/f4a69652/attachment.htm>