[dolphin] [Bug 415698] VCS plugin function calls redundant

[Elvis Angelaccio]

https://bugs.kde.org/show_bug.cgi?id=415698

Elvis Angelaccio <elvis.angelaccio at kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REPORTED                    |RESOLVED
         Resolution|---                         |FIXED
      Latest Commit|                            |https://commits.kde.org/dol
                   |                            |phin/305085b58143c431d9abb7
                   |                            |bd8dcb2f0954df725a
   Version Fixed In|                            |20.04.0

--- Comment #3 from Elvis Angelaccio <elvis.angelaccio at kde.org> ---
Git commit 305085b58143c431d9abb7bd8dcb2f0954df725a by Elvis Angelaccio, on
behalf of Nikolai Krasheninnikov.
Committed on 26/01/2020 at 16:09.
Pushed by elvisangelaccio into branch 'master'.

Fixes multiple VCS plugin calls on single directory update.

Summary:
Fixes multiple VCS plugin beginRetrival()/endRetrival()/itemVersion() calls on
single directory update.
When VCS pluging finished gathering directory information
VersionControlObserver::slotThreadFinished() calls KFileItemModel::setData() on
each entry with appropriate item VCS information.
This in turn emits KFileItemModel::itemsChanged() which is connected with
VersionControlObserver::delayedDirectoryVerification() which is starting to
gather VCS directory information again.
This commits breaks the vicious circle.
FIXED-IN: 20.04.0

Reviewers: #dolphin, meven, ngraham, elvisangelaccio

Subscribers: kfm-devel

Tags: #dolphin

Differential Revision: https://phabricator.kde.org/D26721

M  +14   -2    src/views/versioncontrol/versioncontrolobserver.cpp
M  +7    -0    src/views/versioncontrol/versioncontrolobserver.h

https://commits.kde.org/dolphin/305085b58143c431d9abb7bd8dcb2f0954df725a

-- 
You are receiving this mail because:
You are on the CC list for the bug.