D26721: Fixes multiple VCS plugin calls on single directory update.

[Elvis Angelaccio]

elvisangelaccio added inline comments.

INLINE COMMENTS

> versioncontrolobserver.cpp:144
> +
> +    // Because "version" role is emmited by VCS plugin (ourselfs) we don't need to
> +    // analyze it and update directory item states information. So lets check if

Typo: emitted.

> versioncontrolobserver.h:103
> +     * Invokes delayedDirectoryVerification() on itemsChanged signal.
> +     * This function filter out changes on items which caused by VCS plugin itself.
> +     */

"Invokes delayedDirectoryVerification() only if the itemsChanged() signal has not been triggered by the VCS plugin itself."

> versioncontrolobserver.h:105
> +     */
> +    void verificationOnItemsChanged(const KItemRangeList& itemRanges, const QSet<QByteArray>& roles);
> +

I'd simply call it `slotItemsChanged()`

REVISION DETAIL
  https://phabricator.kde.org/D26721

To: nikolaik, #dolphin, meven, ngraham, elvisangelaccio
Cc: kfm-devel, pberestov, iasensio, fprice, MrPepe, fbampaloukas, alexde, Codezela, feverfew, meven, spoorun, navarromorales, firef, ngraham, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20200126/af93a0b5/attachment.htm>