D26259: Fixes svn plugin issuing "mkfifo" on Windows.

[Elvis Angelaccio]

elvisangelaccio added inline comments.

INLINE COMMENTS

> fileviewsvnplugin.cpp:311
> +    // This temporary file will be deleted on Dolphin close. We make an assumption:
> +    // when the file got deleted diff program should already load it and no longer needs it.
> +    const QString tmpFileNameTemplate = QString("%1/%2.XXXXXX").arg(QDir::tempPath(), QDir(m_contextDir).dirName());

Please write "when the file gets deleted kompare has already loaded it and no longer needs it."

> fileviewsvnplugin.cpp:336
> +
> +    bool diffStart = QProcess::startDetached(
> +        QLatin1String("kompare"),

Please call it `started` and make it `const`.

REVISION DETAIL
  https://phabricator.kde.org/D26259

To: nikolaik, #dolphin, elvisangelaccio, meven, ngraham
Cc: anthonyfieroni
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20200125/746243b0/attachment.htm>