D16353: Change color(NegativeBackground) of status bar in space info when storage exceeds 90%

Méven Car noreply at phabricator.kde.org
Thu Jan 16 15:44:21 GMT 2020


meven added a comment.


  In D16353#595461 <https://phabricator.kde.org/D16353#595461>, @cfeck wrote:
  
  > Could you please first update the code here to request feedback? I still see `new_palette.setBrush(QPalette::Highlight, colorScheme.foreground(KColorScheme::ActiveText))` which is wrong, because `QPalette::Highlight` is a background color role, not a foreground color role.
  
  
  Well as I said breeze uses `QPalette::Highlight` to draw CapacityBar ( rendered as ProgressBar by breeze) in breezestyle.cpp  `Style::drawProgressBarContentsControl( const QStyleOption* option, QPainter* painter, const QWidget* ) const`
  
  So I have update code to handle both case : breeze style and Fusion based style.
  
  I have added screenshots to the commit comment.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D16353

To: meven, ngraham, pino, elvisangelaccio, #dolphin, sourabhboss
Cc: meven, cfeck, kfm-devel, pberestov, iasensio, fprice, MrPepe, fbampaloukas, alexde, Codezela, feverfew, spoorun, navarromorales, firef, ngraham, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20200116/b4e5a96f/attachment.htm>


More information about the kfm-devel mailing list