D16353: Change color(NegativeBackground) of status bar in space info when storage exceeds 90%

[Méven Car]

meven added a comment.


  In D16353#584292 <https://phabricator.kde.org/D16353#584292>, @meven wrote:
  
  > In D16353#584264 <https://phabricator.kde.org/D16353#584264>, @cfeck wrote:
  >
  > > You marked my issues as Done but didn't change the code there. Please test with CheckColorRoles on Fusion widget style.
  >
  >
  > Thank you for pointing this out.
  >
  > Default KCapactityBar style uses `palette().window().color()` to get its filling color (QPalette::Base color).
  >
  > But breeze uses:
  >
  >   //! styled painting for KCapacityBar
  >   QStyle::ControlElement CE_CapacityBar;
  >
  >
  > from breeze/kstyle/breezestyle.h
  >
  > My curront code works for breeze but not for Fusion.
  >
  > Using for fusion :
  >
  >   new_palette.setBrush(QPalette::Base, colorScheme.foreground(KColorScheme::NegativeText));
  >   
  >
  > Works.
  >
  > F7849140: Screenshot_20191229_175350.png <https://phabricator.kde.org/F7849140>
  >
  > So I guess I have to cover the two cases, breeze and more fusion like themes.
  
  
  Does this make sense @cfeck ?

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D16353

To: meven, ngraham, pino, elvisangelaccio, #dolphin, sourabhboss
Cc: meven, cfeck, kfm-devel, pberestov, iasensio, fprice, MrPepe, fbampaloukas, alexde, Codezela, feverfew, spoorun, navarromorales, firef, ngraham, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20200116/fb9b5254/attachment.htm>