[frameworks-kwidgetsaddons] [Bug 416204] It is possible to place | into "Are you sure you want to open X items?" warning

Nate Graham bugzilla_noreply at kde.org
Tue Jan 14 18:40:29 GMT 2020


https://bugs.kde.org/show_bug.cgi?id=416204

Nate Graham <nate at kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
   Version Fixed In|                            |5.67
         Resolution|---                         |FIXED
      Latest Commit|                            |https://commits.kde.org/kwi
                   |                            |dgetsaddons/945f1849cc24610
                   |                            |7d20d92768b67a2010f2fae39

--- Comment #7 from Nate Graham <nate at kde.org> ---
Git commit 945f1849cc246107d20d92768b67a2010f2fae39 by Nate Graham.
Committed on 14/01/2020 at 18:40.
Pushed by ngraham into branch 'master'.

[KMessageBox] Only allow selecting text in the dialog box using the mouse

Summary:
Right now, when you select text in the dialog box, an insertion point appears.
It never
disappears. This looks odd: {F7882083}

The insertion point allows you to navigate the text using the keyboard. But
this is kind
of pointless since you have to use the mouse to make the insertion point appear
in the
text in the first place, so you might as well just use the mouse to make the
selection.

This patch makes the text only mouse-selectable. Dolphin recently did the same
thing
for its Information Panel labels in D25241 for the same reason.
FIXED-IN: 5.67

Test Plan:
Try to open 6 items at once in Dolphin and click-and-drag in the message box
text.
Test is still selectable, but an insertion point is no longer created that
cannot be
removed.

Reviewers: dfaure, #frameworks, #vdg, ndavis

Reviewed By: #vdg, ndavis

Subscribers: broulik, kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D26649

M  +2    -2    src/kmessagebox.cpp

https://commits.kde.org/kwidgetsaddons/945f1849cc246107d20d92768b67a2010f2fae39

-- 
You are receiving this mail because:
You are on the CC list for the bug.



More information about the kfm-devel mailing list