D26648: Improved quality of JPEG thumbnails

[Méven Car]

meven added subscribers: volkov, meven.
meven added a comment.


  Nice first patch @chroniceel !
  
  https://github.com/openwebos/qt/blob/master/src/gui/image/qimagereader.cpp#L1202 is the only use of quality in ImageReader, its default is -1 so it depends on its https://doc.qt.io/qt-5/qimageiohandler.html to choose the default behavior and its documentation is not more precise either.
  We probably should pick ourselves a value so that if Qt changes its default we are not affected and to set the performance level ourselves. 80 or 90 seems like reasonable values as mentioned by @ngraham before.
  
  This line was added in c249f8547f2d1913e0570d78a0240c5f8865c336 <https://phabricator.kde.org/R320:c249f8547f2d1913e0570d78a0240c5f8865c336>
  So @volkov maybe you have some input ?
  
  You can add `FIXED-IN: 20.04` to the commit comment, following our commit policy https://community.kde.org/Policies/Commit_Policy to automatically close the bug when it lands.

REVISION DETAIL
  https://phabricator.kde.org/D26648

To: chroniceel, broulik, #frameworks, #vdg
Cc: meven, volkov, cfeck, bruns, ngraham, kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, michaelh, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20200114/b64ae025/attachment.htm>