[dolphin] [Bug 416064] Context menu option 'add to places' shouldn't show the entire name

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=416064

Nate Graham <nate at kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
   Version Fixed In|                            |20.04.0
      Latest Commit|                            |https://commits.kde.org/dol
                   |                            |phin/897ce8480c9c281f0501d2
                   |                            |01e33b6b0e8e7dd9a6
         Resolution|---                         |FIXED

--- Comment #3 from Nate Graham <nate at kde.org> ---
Git commit 897ce8480c9c281f0501d201e33b6b0e8e7dd9a6 by Nate Graham.
Committed on 13/01/2020 at 15:11.
Pushed by ngraham into branch 'master'.

Use more conventional "Add to Places" text for that action

Summary:
I originally implemented this to show "Add <current folder> to Places" to make
the menu
item more clear when invoked from the file menu or the viewport context menu
because I
thought it wasn't totally clear that the action would be referring to the
folder for the
visible view.

However I think in retrospect that this was a mistake. No other items in the
file menu
or the viewport context menu name the current folder like this, so clearly
there wasn't
a problem. And then the item's text doesn't match the text for other items.

Thie patch removes that behavior and makes the name match the style of all the
other menu
item text.
FIXED-IN: 20.04.0

Reviewers: #dolphin, #vdg, meven

Reviewed By: #dolphin, meven

Subscribers: elvisangelaccio, meven, kfm-devel

Tags: #dolphin

Differential Revision: https://phabricator.kde.org/D26590

M  +1    -3    src/dolphinmainwindow.cpp

https://commits.kde.org/dolphin/897ce8480c9c281f0501d201e33b6b0e8e7dd9a6

-- 
You are receiving this mail because:
You are on the CC list for the bug.