D8208: Add Duplicate feature

[David Faure]

dfaure added inline comments.

INLINE COMMENTS

> dolphinview.cpp:733
> +            extension = QStringLiteral(".") + extension;
> +            const QString directoryPath = originalURL.adjusted(QUrl::RemoveFilename).toString();
> +            const QString originalFilenameWithoutExtension = originalFileName.chopped(extension.size());

path(), not toString().

Or if you really want a full URL in there then call it directoryURL. It means reparsing the whole URL though, I thought we'd just copy the URL and change the path.

> dolphinview.cpp:738
> +            const QString suffixString = originalFileName.right(extension.size());
> +            duplicateURL = QUrl((i18nc("<file path><filename> copy.<extension>", "%1%2 copy%3", directoryPath, originalFilenameWithoutExtension, suffixString)));
> +        }

Why not just put the "." in the format string here?

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D8208

To: ngraham, #dolphin, #kde_applications, elvisangelaccio, dfaure, broulik, davidedmundson
Cc: fvogt, mthw, kfm-devel, meven, markg, fazevedo, cfeck, #dolphin, pberestov, iasensio, fprice, MrPepe, fbampaloukas, alexde, Codezela, feverfew, spoorun, navarromorales, firef, ngraham, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20200111/2ac4f7d7/attachment.htm>