D8208: [WIP] Add Duplicate feature

Fabian Vogt noreply at phabricator.kde.org
Fri Jan 10 21:08:00 GMT 2020


fvogt requested changes to this revision.
fvogt added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> dolphinview.cpp:722
> +        QMimeDatabase db;
> +        const QString extension = db.suffixForFileName(item.name());
> +

Note that this returns a null `QString` if the extension isn't known and also doesn't preserve case.

So currently this would happen:

"test.foo" -> "test.foo"/ ""` -> "test.foo copy"
"test.GIF" -> "test"/ "gif"` -> "test.GIF copy.gif"

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D8208

To: ngraham, #dolphin, #kde_applications, elvisangelaccio, dfaure, broulik, davidedmundson, fvogt
Cc: fvogt, pino, mthw, kfm-devel, meven, markg, fazevedo, cfeck, #dolphin, pberestov, iasensio, fprice, MrPepe, fbampaloukas, alexde, Codezela, feverfew, spoorun, navarromorales, firef, ngraham, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20200110/94e2fa3b/attachment.htm>


More information about the kfm-devel mailing list