D26259: Fixes svn plugin issuing "mkfifo" on Windows.

Méven Car noreply at phabricator.kde.org
Tue Jan 7 14:57:32 GMT 2020


meven requested changes to this revision.
meven added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> CMakeLists.txt:24
>  
> +kde_enable_exceptions()
> +

Remove

> fileviewsvnplugin.cpp:339
> +        if ( !process->waitForStarted() ) {
> +            throw( i18nc("@info:status", "Show changes error: start of kompare failed.") );
> +        }

No need for exceptions here, if you throw it yourself, you can can call what you put in your catch catch directly here, and then return

REPOSITORY
  R449 Plugins for Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D26259

To: nikolaik, #dolphin, elvisangelaccio, meven, ngraham
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20200107/324a88bf/attachment.htm>


More information about the kfm-devel mailing list