D26369: (search) Fix searching tags with spaces

Ismael Asensio noreply at phabricator.kde.org
Mon Jan 6 19:17:25 GMT 2020


iasensio added inline comments.

INLINE COMMENTS

> elvisangelaccio wrote in dolphinfacetswidget.cpp:184-185
> IMHO the new helper function should only strip the quotes. I'd keep the `QString::mid(10)` logic here, because it's clear that we are removing the `modified>=` prefix.

Done. It's more clear indeed.
I just kept `stripQuotes()` for the `tags`case, since it's not necessary in the other ones.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D26369

To: iasensio, #dolphin, elvisangelaccio, ngraham
Cc: kfm-devel, pberestov, iasensio, fprice, MrPepe, fbampaloukas, alexde, Codezela, feverfew, meven, spoorun, navarromorales, firef, ngraham, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20200106/8eb2f6e8/attachment.htm>


More information about the kfm-devel mailing list