D26369: (search) Fix searching tags with spaces

[Elvis Angelaccio]

elvisangelaccio requested changes to this revision.
elvisangelaccio added a comment.
This revision now requires changes to proceed.


  Is it possible to add a test case in `dolphinquerytest.cpp`?

INLINE COMMENTS

> dolphinfacetswidget.cpp:184-185
>  {
>      if (term.startsWith(QLatin1String("modified>="))) {
> -        const QString value = term.mid(10);
> +        const QString value = termValue(term, 10);
>          const QDate date = QDate::fromString(value, Qt::ISODate);

IMHO the new helper function should only strip the quotes. I'd keep the `QString::mid(10)` logic here, because it's clear that we are removing the `modified>=` prefix.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D26369

To: iasensio, #dolphin, elvisangelaccio, ngraham
Cc: kfm-devel, pberestov, iasensio, fprice, MrPepe, fbampaloukas, alexde, Codezela, feverfew, meven, spoorun, navarromorales, firef, ngraham, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20200106/f8e6aa5a/attachment.htm>