D26362: [Tentative] Move from the searchbox to the results

[Nathaniel Graham]

ngraham added a subscriber: elvisangelaccio.
ngraham added a comment.


  Thanks, this is much better technically.
  
  One thing I notice is that moving the focus to the view using `focusViewRequest()` doesn't actually make an item become pre-selected if it wasn't before. Given that the whole point of this feature is to quickly select an item in the view after filtering or searching, maybe it would also make sense to create a new function that will do that which we can call from the filter bar and search field when they request to move focus to the view.
  
  Then again personally I kind of think that focusing the main view should *always* select an item, since otherwise that's just a manual step the user has to do for themselves. In this case, we would have `DolphinViewContainer::requestFocus()` always automatically select the item with implicit focus, if it's not already selected.
  
  What do you think, @elvisangelaccio?

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D26362

To: shlomif, ngraham, #dolphin
Cc: elvisangelaccio, ngraham, iasensio, kfm-devel, pberestov, fprice, MrPepe, fbampaloukas, alexde, Codezela, feverfew, meven, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20200103/f89b4aac/attachment.htm>