D26362: [Tentative] Move from the searchbox to the results

[Nathaniel Graham]

ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  Given that the down arrow key currently does nothing here, I think that this makes sense conceptually. I'm not a huge fan of this `setView()` function though. Instead, pressing the down arrow key should emit `focusViewRequest();` This is how the filter bar implements this functionality.

INLINE COMMENTS

> dolphinsearchbox.cpp:224
> +    else if (event->key() == Qt::Key_Down) {
> +        Q_ASSERT(m_view);
> +        m_view->setFocus();

don't assert; instead check for `m_view` being valid, and if it isn't, just do nothing.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D26362

To: shlomif, ngraham
Cc: ngraham, iasensio, kfm-devel, pberestov, fprice, MrPepe, fbampaloukas, alexde, Codezela, feverfew, meven, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20200103/d9230b52/attachment.htm>