D26343: (search) Keep menu open when selecting tags

Ismael Asensio noreply at phabricator.kde.org
Wed Jan 1 15:06:49 GMT 2020


iasensio created this revision.
iasensio added reviewers: Dolphin, elvisangelaccio, ngraham.
Herald added a project: Dolphin.
Herald added a subscriber: kfm-devel.
iasensio requested review of this revision.

REVISION SUMMARY
  Keeps the `Tags` menu open while selecting and deselecting tags in the
  search panel, saving many mouse clicks for multiple tags.
  It cannot be done natively on `QMenu` (https://bugreports.qt.io/browse/QTBUG-6635)
  but it is a one-liner and I haven't seen any bad behavior so far.

TEST PLAN
  - `Tags` menu does not close when selecting/deselecting tags
  - Tag search is consistent
  - Clicking anywhere else will close the menu
  
  F7853705: search_tags_sticky.gif <https://phabricator.kde.org/F7853705>

REPOSITORY
  R318 Dolphin

BRANCH
  search_tags_sticky

REVISION DETAIL
  https://phabricator.kde.org/D26343

AFFECTED FILES
  src/search/dolphinfacetswidget.cpp

To: iasensio, #dolphin, elvisangelaccio, ngraham
Cc: kfm-devel, pberestov, iasensio, fprice, MrPepe, fbampaloukas, alexde, Codezela, feverfew, meven, spoorun, navarromorales, firef, ngraham, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20200101/6ac84507/attachment.htm>


More information about the kfm-devel mailing list