D27647: throw out the windows variant of the smb slave
Harald Sitter
noreply at phabricator.kde.org
Tue Feb 25 13:02:04 GMT 2020
sitter created this revision.
sitter added a reviewer: ngraham.
Herald added projects: Dolphin, Frameworks.
Herald added subscribers: kfm-devel, kde-frameworks-devel.
sitter requested review of this revision.
REVISION SUMMARY
it hasn't been built in ages because the top level cmakelists actually only
adds the smb dir when samba is found (which would be never I guess?).
it is also continuously ignored when sweeping changes are made (such as
the move to json plugin metadata or the debug category change).
overall it is entirely useless as native UNC path handling seems to work
just fine these days in for example okular and kate. so, I very much
believe that bespoke smb handling is entirely moot on windows (as it
should be, really)
TEST PLAN
okular and kate still open remote UNC paths without it on windows
REPOSITORY
R320 KIO Extras
BRANCH
smb-no-win
REVISION DETAIL
https://phabricator.kde.org/D27647
AFFECTED FILES
smb/CMakeLists.txt
smb/kio_smb_win.cpp
smb/kio_smb_win.h
To: sitter, ngraham
Cc: kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, cblack, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20200225/475c303d/attachment.htm>
More information about the kfm-devel
mailing list