D27646: smb: apply a whole bunch of static analyzer improvements

[Harald Sitter]

sitter created this revision.
sitter added a reviewer: ngraham.
Herald added projects: Dolphin, Frameworks.
Herald added subscribers: kfm-devel, kde-frameworks-devel.
sitter requested review of this revision.

REVISION SUMMARY
  among other things:
  
  - {} initialize the posix structs
  - =default d/ctors where appropriate
  - synced argument names between header and cpp
  - no c-style casting
  - while(true) instead of while(1)
  - initialize class members that could previously have gone uninitialized
  - no single-line-multi-variable declaration

TEST PLAN
  builds

REPOSITORY
  R320 KIO Extras

BRANCH
  tidy

REVISION DETAIL
  https://phabricator.kde.org/D27646

AFFECTED FILES
  smb/dnssddiscoverer.cpp
  smb/kio_smb.cpp
  smb/kio_smb.h
  smb/kio_smb_auth.cpp
  smb/kio_smb_browse.cpp
  smb/kio_smb_dir.cpp
  smb/kio_smb_file.cpp
  smb/kio_smb_internal.cpp
  smb/kio_smb_internal.h
  smb/kio_smb_mount.cpp

To: sitter, ngraham
Cc: kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, cblack, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20200225/a2c74599/attachment.htm>