[dolphin] [Bug 416989] Konqueror's terminal window does not start in current directory

[Elvis Angelaccio]

https://bugs.kde.org/show_bug.cgi?id=416989

Elvis Angelaccio <elvis.angelaccio at kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |elvis.angelaccio at kde.org

--- Comment #3 from Elvis Angelaccio <elvis.angelaccio at kde.org> ---
(In reply to Jonathan Marten from comment #0)
> SUMMARY
> 
> Yes, this bug is being initially reported for Dolphin, because even though
> the problem only shows up in Konqueror the bug seems to be either in the
> DolphinPart or KParts.
> 
> When using Konqueror's Tools - Open Terminal action (F4), the terminal shell
> should start in the directory shown in the file manager.  Since
> https://phabricator.kde.org/D26140 this is not the case, the terminal always
> starts in $HOME.
> 
> In DolphinPart::slotOpenTerminal() that change replaced the stat and local
> file conversion with KParts::ReadOnlyPart::localFilePath().  localFilePath()
> returns d->m_file, which is never set by any function that DolphinPart
> calls;  it remains as null and so the KToolInvocation::invokeTerminal()
> always starts in the home directory.
> 
> DolphinPart::openUrl() calls KParts::ReadOnlyPart::setUrl() with the comment
> "remember it at the KParts level", but KParts::ReadOnlyPart::setUrl() does
> not set d->m_file, only KParts::ReadOnlyPart::openUrl() does.
> 
> Possible solutions that I can think of would be either:
> 
> (a) Call KParts::ReadOnlyPart::openUrl() instead of setUrl() in
> DolphinPart::openUrl().

This looks like the simpler solution to me. Any volunteer?

-- 
You are receiving this mail because:
You are on the CC list for the bug.