D27504: WIP: RFC: smb faster copy to local

[Anthony Fieroni]

anthonyfieroni added inline comments.

INLINE COMMENTS

> kio_smb_dir.cpp:49
> +        : segmentSize(static_cast<size_t>(segmentSize_)) // won't be <0
> +        , buf(static_cast<char *>(malloc(segmentSize)))
> +    {

Segment does not free its memory. Why not use QByteArray or similar with automatic storage allocation?

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D27504

To: sitter, ngraham, cfeck
Cc: anthonyfieroni, asturmlechner, kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, cblack, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20200219/08fe1dbf/attachment.htm>