D27389: Fix files not being highlighted if directory of file is already open

[Alexander Saoutkin]

feverfew created this revision.
feverfew added a reviewer: broulik.
Herald added a project: Dolphin.
Herald added a subscriber: kfm-devel.
feverfew requested review of this revision.

REVISION SUMMARY
  In DolphinTabWidget::openFiles it assumes openDirectories will open new tabs, so it
  only marks the URL selection for the newly opened tabs. This assumption is incorrect
   as Dolphin might reuse tabs when the folder is already open.
  
  Even then, markUrlsAsSelected does nothing when the folder is already opened.
  The selection seems to only be used when the folder finishes loading, calls made after
  that only change a variable without updating the actual selection.
  
  A call to updateViewState() is required to restore the intended behaviour.
  This is now also called in setActive(), and setActive() is called on
  every openFiles() call in every tab.
  
  BUG: 417230
  FIXED-IN: 19.12.3

TEST PLAN
  Manual, as described in bug report

REPOSITORY
  R318 Dolphin

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27389

AFFECTED FILES
  src/dolphintabwidget.cpp
  src/views/dolphinview.cpp

To: feverfew, broulik
Cc: kfm-devel, pberestov, iasensio, fprice, MrPepe, fbampaloukas, alexde, Codezela, feverfew, meven, spoorun, navarromorales, firef, ngraham, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20200214/2f83c087/attachment.htm>