D27291: install smb as both smb:// and cifs://

[Harald Sitter]

sitter created this revision.
sitter added a reviewer: dfaure.
Herald added projects: Dolphin, Frameworks.
Herald added subscribers: kfm-devel, kde-frameworks-devel.
sitter requested review of this revision.

REVISION SUMMARY
  the latter while not IANA registered is apparently used in places. to
  cheaply support it we now configure the protocol file for both protocol
  'smb' and 'cifs' and installing two protocol files. they are still both
  backed by the same plugin and otherwise the same.
  code-wise this also required adjustments to the URL validation tech as
  it has hardcoded checks for smb schemes.
  
  FIXED-IN: 19.12.3
  BUG: 327295

TEST PLAN
  - cifs://host/share
  - cifs://host
  - cifs://
  
  all open correctly. they do get translated to smb because of the checkUrl code.
  
  checkUrl seems entirely pointless, SMBUrl does a bit of validation/fixing as part of
  updateCache. It occurs to me checkUrl should simply be incorporated into SMBUrl
  and we should construct an SMBUrl where we previously called checkUrl. before doing
  anything of value we construct SMBUrls anyway, so the isolated logic does absolutely
  nothing SMBUrl couldn't do just as well. also needs a unit test -.- ... too much 
  refactoring for a bugfix though

REPOSITORY
  R320 KIO Extras

BRANCH
  bug327295

REVISION DETAIL
  https://phabricator.kde.org/D27291

AFFECTED FILES
  smb/CMakeLists.txt
  smb/kio_smb_browse.cpp
  smb/kio_smb_internal.cpp
  smb/smb.protocol
  smb/smb.protocol.cmake

To: sitter, dfaure
Cc: kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, cblack, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20200210/163fe539/attachment.htm>