[dolphin] [Bug 388922] Clicking arrow beside samba share expands them all on top level

[Harald Sitter]

https://bugs.kde.org/show_bug.cgi?id=388922

Harald Sitter <sitter at kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|17.12.1                     |19.12.2
             Status|REPORTED                    |CONFIRMED
           Assignee|plasma-bugs at kde.org         |dolphin-bugs-null at kde.org
     Ever confirmed|0                           |1
          Component|Samba                       |view-engine: details mode
            Product|kio-extras                  |dolphin
                 CC|                            |kfm-devel at kde.org,
                   |                            |sitter at kde.org

--- Comment #1 from Harald Sitter <sitter at kde.org> ---
This is a bug in KFileItemModel::index. It fails to map the expanded URLs to
their parent when that parent was originally listed without trailing slash.

e.g listDir of smb gives out `smb://ajax.local` and its children will be
`smb://ajax.local/Public`.

::index tries to mitigate this by stripping the trailing slash
> const QUrl urlToFind = url.adjusted(QUrl::StripTrailingSlash);
I am guessing this is noop for smb://ajax.local/ because that slash is
technically not trailing but denotes the root.

> dolphin(16343)/(default) KFileItemModel::index: urlToFind QUrl("smb://ajax.local/")
> dolphin(16343)/(default) KFileItemModel::index: items QHash((QUrl("smb://ajax.local"), 0)(QUrl("smb://ubuntu.local"), 1))

This may well be a bug in QUrl because those urls really should be considered
equal, but their may be nuances I'm not aware of. I seem to remember something
about scheme-dependent path defaults, which I guess would make "" not
necessarily == "/"

-- 
You are receiving this mail because:
You are on the CC list for the bug.