D27790: update KParts' ReadOnlyPart::localFilePath in DolphinPart::openUrl()

Piotr Dabrowski noreply at phabricator.kde.org
Tue Dec 29 16:16:55 GMT 2020


pdabrowski marked 2 inline comments as done.
pdabrowski added inline comments.

INLINE COMMENTS

> elvisangelaccio wrote in dolphinpart.cpp:322
> @pdabrowski Ping?

Yes, `KParts::ReadOnlyPart::openUrl()` seems to work fine here.
I'm not sure if there were any corner cases, but I tested this now with Konqueror, and it works.
Added merge request: https://invent.kde.org/system/dolphin/-/merge_requests/151/

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D27790

To: pdabrowski, #dolphin, elvisangelaccio, ngraham
Cc: kfm-devel, badbunny, waitquietly, azyx, nikolaik, pberestov, iasensio, aprcela, fprice, fbampaloukas, alexde, Codezela, feverfew, meven, spoorun, navarromorales, firef, ngraham, andrebarros, emmanuelp, rdieter, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kfm-devel/attachments/20201229/6101188b/attachment-0001.htm>


More information about the kfm-devel mailing list