D24907: Fix error handling when renaming a single file

Elvis Angelaccio noreply at phabricator.kde.org
Mon Dec 28 22:03:33 GMT 2020


elvisangelaccio requested changes to this revision.
elvisangelaccio added a comment.
This revision now requires changes to proceed.


  Sorry for the delay. 
  Patch looks good beside the inline comment. @alexmi Can you fix it?

INLINE COMMENTS

> dolphinview.cpp:1638
> -
> -            forceUrlsSelection(newUrl, {newUrl});
> -

This is still needed, otherwise the renamed file won't get selected.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D24907

To: alexmi, #vdg, #dolphin, elvisangelaccio
Cc: meven, kfm-devel, badbunny, waitquietly, azyx, nikolaik, pberestov, iasensio, aprcela, fprice, fbampaloukas, alexde, Codezela, feverfew, spoorun, navarromorales, firef, ngraham, andrebarros, emmanuelp, rdieter, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kfm-devel/attachments/20201228/9a00e50b/attachment.htm>


More information about the kfm-devel mailing list