[dolphin] [Bug 430293] "Open With" for folders missing in context menu

[Méven Car]

https://bugs.kde.org/show_bug.cgi?id=430293

Méven Car <meven.car at enioka.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REPORTED                    |CONFIRMED
                 CC|                            |meven.car at enioka.com
     Ever confirmed|0                           |1

--- Comment #10 from Méven Car <meven.car at enioka.com> ---
(In reply to Maxim from comment #8)
> (In reply to Nate Graham from comment #3)
> > I believe this was an intentional change, to reduce the humongous length of
> > the context menu. On my setup, the only item in the "Open With" menu was
> > Gwenview, which was redundant with the fileitemaction plugin. I guess you
> > have Konqueror in yours.
> > 
> > I can understand that from your perspective this is a regression, but isn't
> > it a pretty niche use case to use Dolphin to open a location in Konqueror?
> > 
> > We gotta keep the context menu's size reasonable somehow... :(
> 
> A little question - https://bugs.kde.org/show_bug.cgi?id=430304 possibly is
> also intentional change or a real bug?

That is not the same bug, although related to the same code.

Here the bug was caused by :
https://invent.kde.org/frameworks/kio/-/commit/7787e497ad74676e412a9e6360171aef4660014d#51600055525abe6783ac71d35337895019a4eec4_367_341

Line `if (isDir || !isLocal) {` should be `if (isDir && !isLocal) {`
That's a classic mistake : !(a || b) == !a && !b where here we have !a || !b
which is not equivalent.

To re-enable "Open With" for local folders.

-- 
You are receiving this mail because:
You are on the CC list for the bug.