[dolphin] [Bug 426898] Dolphin not opening

[Martin Sandsmark]

https://bugs.kde.org/show_bug.cgi?id=426898

Martin Sandsmark <martin.sandsmark at kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kde at privat.broulik.de,
                   |                            |martin.sandsmark at kde.org

--- Comment #6 from Martin Sandsmark <martin.sandsmark at kde.org> ---
Introduced by this, I think:

commit 9f268f5f76a4a4f0c91abcc213e159c8bde4869c
  Author: Kai Uwe Broulik <kde at privat.broulik.de>
  Date:   Tue May 5 12:05:18 2020 +0200

      Don't use local URL for KMoreTool

      This method is called a billion times and spawns a blocking(!) StatJob.
      KFind can search local URLs, too, so I don't see why this is necessary.
      Either way, I'd rather have a non-KDE search tool broken than the app.
      Ideally, I'd like this entire thing redone to use an async StatJob, if
any.
      Fwiw the KMoreTools in the free space bar doesn't use a local URL either.

      BUG: 420911
      FIXED-IN: 20.04.1

      Differential Revision: https://phabricator.kde.org/D29442

  diff --git src/dolphinmainwindow.cpp src/dolphinmainwindow.cpp
  index f88bc3f44..7ad136fe7 100644
  --- src/dolphinmainwindow.cpp
  +++ src/dolphinmainwindow.cpp
  @@ -956,7 +956,7 @@ QPointer<QAction>
DolphinMainWindow::preferredSearchTool()
   {
       m_searchTools.clear();
       KMoreToolsMenuFactory("dolphin/search-tools").fillMenuFromGroupingNames(
  -        &m_searchTools, { "files-find" },
QUrl::fromLocalFile(activeContainerLocalPath())
  +        &m_searchTools, { "files-find" }, m_activeViewContainer->url()
       );
       QList<QAction*> actions = m_searchTools.actions();
       if (actions.isEmpty()) {

-- 
You are receiving this mail because:
You are on the CC list for the bug.