D28745: Skip caching thumbnails on encrypted filesystems

[Stefan Brüns]

bruns added inline comments.

INLINE COMMENTS

> thumbnail.cpp:62
> +#include <Solid/StorageAccess>
> +#include <Solid/StorageVolume>
>  

What are all these includes for?

> thumbnail.cpp:563
>  
> -            if (validThumbnails > 0 && hadFirstThumbnail == dir.filePath()) {
> +            if (validThumbnails > 0 && hadFirstThumbnail == canonicalFilePath) {
>                  break; // Never show the same thumbnail twice

Obviously broken, as hadFirstThumbnail is not set from a canonical path ..

Or not so obvious, as this is still lacking context.

> thumbnail.cpp:743
> +                    allowCache = device.as<Solid::StorageVolume>()->usage() != Solid::StorageVolume::UsageType::Encrypted;
> +                }
> +            }

Why is all this code called even when ThumbCreator::create fails?

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D28745

To: marcingu, ivan, broulik, #dolphin, ngraham, meven, bruns, dfaure
Cc: dfaure, thiago, bruns, meven, ngraham, kde-frameworks-devel, kfm-devel, waitquietly, azyx, nikolaik, pberestov, iasensio, aprcela, fprice, LeGast00n, cblack, fbampaloukas, alexde, Codezela, feverfew, michaelh, spoorun, navarromorales, firef, andrebarros, emmanuelp, rdieter, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20200824/5d55459c/attachment.htm>