[frameworks-kcoreaddons] [Bug 423818] KDirWatch's useFam loops indefinitely (actual fam, not gamin)

[Harald Sitter]

https://bugs.kde.org/show_bug.cgi?id=423818

Harald Sitter <sitter at kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Latest Commit|                            |https://invent.kde.org/fram
                   |                            |eworks/kcoreaddons/commit/8
                   |                            |599c4d58b82ad0096d59a4a23e5
                   |                            |4d75b5c7f558
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED
   Version Fixed In|                            |5.74

--- Comment #14 from Harald Sitter <sitter at kde.org> ---
Git commit 8599c4d58b82ad0096d59a4a23e54d75b5c7f558 by Harald Sitter.
Committed on 20/08/2020 at 13:59.
Pushed by sitter into branch 'master'.

do not wait for fam events indefinitely

when famEventReceived encountered trouble with getting events it'll
disable FAM entirely and instead register another fallback system. this
means we'll have to check if FAM has been disabled every iteration and
if it has break out of the loop. otherwise we'd loop indefinitely.

we'll now also cap the amount of time (or rather iterations) we'll wait
for the event to arrive. this acts as a safety net against further
infinity loops. what's more, since this will get called from the
main thread the GUI is blocked by us, so, 4s is already a lot all
things considered.

FIXED-IN: 5.74

M  +33   -19   src/lib/io/kdirwatch.cpp
M  +1    -0    src/lib/io/kdirwatch_p.h

https://invent.kde.org/frameworks/kcoreaddons/commit/8599c4d58b82ad0096d59a4a23e54d75b5c7f558

-- 
You are receiving this mail because:
You are on the CC list for the bug.