D29006: Allow to copy or move selection to the other split view

[David Faure]

dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> dolphinmainwindow.cpp:1973
> +        copyToOtherViewAction->setEnabled(false);
> +        moveToOtherViewAction->setEnabled(capabilities.supportsMoving());
>      } else {

What will you move if there are no selected items?

> dolphinmainwindow.cpp:1996
> +            copyToOtherViewAction->setEnabled(false);
> +            moveToOtherViewAction->setEnabled(capabilities.supportsMoving());
> +        }

same here. No split view, the action should be disabled, no?

> dolphinview.cpp:701
> +    QList<QUrl> newSelection;
> +    if (job) {
> +        newSelection << destinationPanelUrl;

job can never be null, this if() can be removed

> dolphinview.cpp:702
> +    if (job) {
> +        newSelection << destinationPanelUrl;
> +        KIO::FileUndoManager::self()->recordCopyJob(job);

unused variable `newSelection`

> dolphinview.cpp:713
> +    QList<QUrl> newSelection;
> +    if (job) {
> +        newSelection << destinationPanelUrl;

same

> dolphinview.cpp:714
> +    if (job) {
> +        newSelection << destinationPanelUrl;
> +        KIO::FileUndoManager::self()->recordCopyJob(job);

same

> dolphinview.h:371
> +     */
> +    void copySelectedItemsToOtherSplitView(KFileItemList selection, QUrl destinationPanelUrl);
> +

const &    for both arguments

(repeats)

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D29006

To: aprcela, #dolphin, elvisangelaccio, ngraham, meven, dfaure
Cc: kde-doc-english, dfaure, meven, kfm-devel, azyx, nikolaik, pberestov, iasensio, aprcela, fprice, gennad, fbampaloukas, alexde, Codezela, feverfew, spoorun, navarromorales, firef, ngraham, andrebarros, skadinna, emmanuelp, rdieter, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20200429/e6a75172/attachment.htm>