D29006: Allow to copy or move selection to the other split view

David Faure noreply at phabricator.kde.org
Wed Apr 29 08:37:45 BST 2020


dfaure added a comment.


  In D29006#659514 <https://phabricator.kde.org/D29006#659514>, @meven wrote:
  
  > In D29006#659406 <https://phabricator.kde.org/D29006#659406>, @dfaure wrote:
  >
  > > One solution would be to fix KDynamicJobTracker to be async, but its API requires that registerJob creates the JobView, all subsequent calls need that....
  >
  >
  > Sounds like a KF6 task. Isn't it ?
  
  
  Actually, the only way I see that this could be fixed is by buffering all calls to setters until the target JobView exists? Sounds messy, but it doesn't actually require an API change.
  E.g. infoMessage() would say
  
    if (d->progressViewsBeingCreated.contains(job)) {
       d->pendingCalls.append(SetInfoMessage, plainText); // I guess a QList<QVariant>? Ugly deserialization... Or std::function can help maybe?
    }
  
  Anyone wants to take care of this interesting problem? ;-)

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D29006

To: aprcela, #dolphin, elvisangelaccio, ngraham, meven
Cc: dfaure, meven, kfm-devel, azyx, nikolaik, pberestov, iasensio, aprcela, fprice, fbampaloukas, alexde, Codezela, feverfew, spoorun, navarromorales, firef, ngraham, andrebarros, emmanuelp, rdieter, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20200429/b6190ed8/attachment.htm>


More information about the kfm-devel mailing list