D29119: Dolphin: Implement package kit for deb/rpm service packages

[Anthony Fieroni]

anthonyfieroni added inline comments.

INLINE COMMENTS

> CMakeLists.txt:5
>  add_executable(servicemenuinstaller servicemenuinstaller.cpp)
> -target_link_libraries(servicemenuinstaller PRIVATE
> +target_link_libraries(servicemenuinstaller
>      Qt5::Core

Unrelated change, keep private linking.

> servicemenuinstaller.cpp:33
>  
> +static QStringList binaryPackages = {"application/vnd.debian.binary-package", "application/x-rpm",
> +                                     "application/x-xz", "application/zstd"};

`const`, `QStringLiteral` to strings.

> servicemenuinstaller.cpp:75
> +                        fail(i18n("Failed to install \"%1\", exited with status \"%2\"",
> +                                  fileName, QVariant::fromValue(status).toString()));
> +                    });

Installation process may fail due to unsatisfied depends can we get more info about?

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D29119

To: alex, #dolphin, ngraham, elvisangelaccio, meven
Cc: anthonyfieroni, asturmlechner, meven, kfm-devel, azyx, nikolaik, pberestov, iasensio, aprcela, fprice, fbampaloukas, alexde, Codezela, feverfew, spoorun, navarromorales, firef, ngraham, andrebarros, emmanuelp, rdieter, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20200427/cc2d21d4/attachment.htm>