D29119: Dolphin: Implement package kit for deb/rpm service packages

[Anthony Fieroni]

anthonyfieroni added inline comments.

INLINE COMMENTS

> CMakeLists.txt:9
>      KF5::I18n
> +    PK::packagekitqt5
>  )

It should be optional.

> servicemenuinstaller.cpp:343
>      } else {
> +        const QStringList binaryPackages = {"application/vnd.debian.binary-package", "application/x-rpm"};
> +        if (binaryPackages.contains(QMimeDatabase().mimeTypeForFile(archive).name())) {

Why limited to these 2? Pacman packages should be included as well.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D29119

To: alex, #dolphin, ngraham, elvisangelaccio, meven
Cc: anthonyfieroni, asturmlechner, meven, kfm-devel, azyx, nikolaik, pberestov, iasensio, aprcela, fprice, fbampaloukas, alexde, Codezela, feverfew, spoorun, navarromorales, firef, ngraham, andrebarros, emmanuelp, rdieter, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20200427/dd04e4d1/attachment.htm>