D28402: Provide ability to configure size cut-off for local file previews

[Elvis Angelaccio]

elvisangelaccio requested changes to this revision.
elvisangelaccio added a comment.
This revision now requires changes to proceed.


  Please add a `#include <QCheckBox>` in  `previewssettingspage.cpp`, otherwise it doesn't build with Qt 5.15.
  
  Is there a reason why we are adding a checkbox only for local files? If yes, please write it in the commit message. And while at it, please remove the "I am a noob" part ;)

INLINE COMMENTS

> previewssettingspage.h:60
>      void loadSettings();
> +    void useTypeChanged();
>  

This shuld be in the `private slots` section. While at it, please call it `toggleLocalFileSize()` or similar, since this is a slot and not a signal.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D28402

To: harogaston, ngraham, #dolphin, meven, elvisangelaccio
Cc: cfeck, kfm-devel, azyx, nikolaik, pberestov, iasensio, aprcela, fprice, fbampaloukas, alexde, Codezela, feverfew, meven, spoorun, navarromorales, firef, ngraham, andrebarros, emmanuelp, rdieter, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20200426/f3815917/attachment.htm>