D29178: [dolphin] : Mac integration

[Elvis Angelaccio]

elvisangelaccio added inline comments.

INLINE COMMENTS

> dolphintabwidget.cpp:337
>  
> -    KIO::CommandLauncherJob *job = new KIO::CommandLauncherJob("dolphin", args, this);
> +    KIO::CommandLauncherJob *job = new KIO::CommandLauncherJob(QCoreApplication::applicationFilePath(), args, this);
>      job->setDesktopName(QStringLiteral("org.kde.dolphin"));

Why is this needed? Can't we fix `KIO::CommandLauncherJob` to also make it work on MacOS? Or at least fix its documention to recommend the usage of `CoreApplication::applicationFilePath()` ?

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D29178

To: rjvbb, #dolphin, elvisangelaccio, feverfew
Cc: feverfew, broulik, meven, kfm-devel, #dolphin, azyx, nikolaik, pberestov, iasensio, aprcela, fprice, fbampaloukas, alexde, Codezela, spoorun, navarromorales, firef, ngraham, andrebarros, emmanuelp, rdieter, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20200426/3b96fdd6/attachment.htm>