D29178: [dolphin] : Mac integration

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> global.cpp:56
>  {
> -    QString command = QStringLiteral("dolphin --new-window");
> +    QString command = QStringLiteral("%1 --new-window").arg(QCoreApplication::applicationFilePath());
>  

I think you need a `KShell::quoteArgs` in case there's spaces in the path

> main.cpp:62
> +            QFileOpenEvent *openEvent = static_cast<QFileOpenEvent*>(event);
> +            qCWarning(DolphinDebug) << "File open event:" << openEvent->url();
> +            urls.append(Dolphin::validateUris(QStringList(openEvent->file())));

This doesn't need to be a warning

> main.cpp:88
> +    DolphinMainWindow* mainWindow = nullptr;
> +    QList<QUrl> urls;
> +};

Make those `private` and add proper getters

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D29178

To: rjvbb, #dolphin, elvisangelaccio
Cc: broulik, meven, kfm-devel, #dolphin, azyx, nikolaik, pberestov, iasensio, aprcela, fprice, fbampaloukas, alexde, Codezela, feverfew, spoorun, navarromorales, firef, ngraham, andrebarros, emmanuelp, rdieter, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20200425/a868255a/attachment.htm>