D28909: smb: port to Result system to force serialization of error/finish condition

[Méven Car]

meven added inline comments.

INLINE COMMENTS

> dfaure wrote in kio_smb.h:96
> Excellent idea, but why wait for KF6?
> 
> We could implement a subclass of SlaveBase, in KIO, let's call it SlaveBaseV2, which
> 
> - Reimplements all the virtual methods from SlaveBase, in a private section
> - Defines a new of virtual methods, called differently somehow
> - Implements the signal emission based on the return value of those new virtual methods.
> 
> This allows for incremental porting of the slaves, instead of a big KF6 breakage.
> And the V2 class can be developed in a single slave first, before having to freeze its API.

Sounds like a nice idea.

File ioslave would be the best one to work on first IMO, since it is the one the most complete, used and tested, albeit one of the biggest probably.

Let's make a task !

But this diff does not need to wait for this.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D28909

To: sitter, dfaure
Cc: meven, kde-frameworks-devel, kfm-devel, azyx, nikolaik, pberestov, iasensio, aprcela, fprice, LeGast00n, cblack, fbampaloukas, alexde, Codezela, feverfew, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, rdieter, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20200425/80490405/attachment.htm>