D29006: Allow to copy or move selection to the other split view

Fri Apr 24 12:44:42 BST 2020

aprcela added a comment.

  The normal copy is made up like this:
  `QAction* copyAction = KStandardAction::copy(this, &DolphinMainWindow::copy, actionCollection())`

  `copySelectedItemsToOtherSplitView()` only does a call to `copySelectedItems()` as `copy()` does

  Maybe I should do something like `KStandardAction::copy(this, &DolphinMainWindow::copyToOtherView, actionCollection())` ?

  Here is the bt when the notification options are set and Dolphin stops responding: ( I shortened the path to the dolphin files a bit )

    (gdb) thread apply all bt

    Thread 4 (Thread 0x7fffe6289700 (LWP 181958)):
    #0  0x00007ffff545eabf in poll () from /usr/lib/libc.so.6
    #1  0x00007ffff3cd64a0 in ?? () from /usr/lib/libglib-2.0.so.0
    #2  0x00007ffff3cd6571 in g_main_context_iteration () from /usr/lib/libglib-2.0.so.0
    #3  0x00007ffff5b78890 in QEventDispatcherGlib::processEvents(QFlags<QEventLoop::ProcessEventsFlag>) () from /usr/lib/libQt5Core.so.5
    #4  0x00007ffff5b1f05c in QEventLoop::exec(QFlags<QEventLoop::ProcessEventsFlag>) () from /usr/lib/libQt5Core.so.5
    #5  0x00007ffff5943c62 in QThread::exec() () from /usr/lib/libQt5Core.so.5
    #6  0x00007ffff5944dd6 in ?? () from /usr/lib/libQt5Core.so.5
    #7  0x00007ffff4fb346f in start_thread () from /usr/lib/libpthread.so.0
    #8  0x00007ffff54693d3 in clone () from /usr/lib/libc.so.6

    Thread 3 (Thread 0x7fffeebf2700 (LWP 181957)):
    #0  0x00007ffff545eabf in poll () from /usr/lib/libc.so.6
    #1  0x00007ffff3cd64a0 in ?? () from /usr/lib/libglib-2.0.so.0
    #2  0x00007ffff3cd6571 in g_main_context_iteration () from /usr/lib/libglib-2.0.so.0
    #3  0x00007ffff5b78890 in QEventDispatcherGlib::processEvents(QFlags<QEventLoop::ProcessEventsFlag>) () from /usr/lib/libQt5Core.so.5
    #4  0x00007ffff5b1f05c in QEventLoop::exec(QFlags<QEventLoop::ProcessEventsFlag>) () from /usr/lib/libQt5Core.so.5
    #5  0x00007ffff5943c62 in QThread::exec() () from /usr/lib/libQt5Core.so.5
    #6  0x00007ffff6c59b28 in ?? () from /usr/lib/libQt5DBus.so.5
    #7  0x00007ffff5944dd6 in ?? () from /usr/lib/libQt5Core.so.5
    #8  0x00007ffff4fb346f in start_thread () from /usr/lib/libpthread.so.0
    #9  0x00007ffff54693d3 in clone () from /usr/lib/libc.so.6

    Thread 2 (Thread 0x7fffef7a2700 (LWP 181956)):
    #0  0x00007ffff545eabf in poll () from /usr/lib/libc.so.6
    #1  0x00007ffff484463b in ?? () from /usr/lib/libxcb.so.1
    #2  0x00007ffff484637b in xcb_wait_for_event () from /usr/lib/libxcb.so.1
    #3  0x00007ffff0132e01 in ?? () from /usr/lib/libQt5XcbQpa.so.5
    #4  0x00007ffff5944dd6 in ?? () from /usr/lib/libQt5Core.so.5
    #5  0x00007ffff4fb346f in start_thread () from /usr/lib/libpthread.so.0
    #6  0x00007ffff54693d3 in clone () from /usr/lib/libc.so.6

    Thread 1 (Thread 0x7ffff0827880 (LWP 181946)):
    #0  0x00007ffff4fb9cf5 in pthread_cond_wait@@GLIBC_2.3.2 () from /usr/lib/libpthread.so.0
    #1  0x00007ffff594aac4 in QWaitCondition::wait(QMutex*, QDeadlineTimer) () from /usr/lib/libQt5Core.so.5
    #2  0x00007ffff594aba2 in QWaitCondition::wait(QMutex*, unsigned long) () from /usr/lib/libQt5Core.so.5
    #3  0x00007ffff6cbe5e8 in ?? () from /usr/lib/libQt5DBus.so.5
    #4  0x00007ffff79342da in QDBusReply<QDBusObjectPath>::operator= (pcall=..., this=0x7fffffffd310) at /usr/include/qt/QtDBus/qdbusreply.h:79
    #5  QDBusReply<QDBusObjectPath>::QDBusReply (reply=..., this=0x7fffffffd310) at /usr/include/qt/QtDBus/qdbusreply.h:87
    #6  KUiServerJobTracker::registerJob (this=<optimized out>, job=<optimized out>) at /kde/src/kjobwidgets/src/kuiserverjobtracker.cpp:126
    #7  0x00007ffff7a6a649 in KDynamicJobTracker::registerJob (this=0x7ffff7ac1c00 <(anonymous namespace)::Q_QGS_globalJobTracker::innerFunction()::holder>, job=0x555555e65260) at /kde/src/kio/src/widgets/kdynamicjobtracker.cpp:108
    #8  0x00007ffff73bafd1 in KIO::CopyJobPrivate::newJob (flags=..., asMethod=false, mode=KIO::CopyJob::Copy, dest=..., src=...) at /kde/src/kio/src/core/copyjob.cpp:280
    #9  KIO::copy (src=..., dest=..., flags=...) at /kde/src/kio/src/core/copyjob.cpp:2269
    #10 0x00007ffff7a5b849 in KIO::PasteJobPrivate::slotStart (this=0x555555eae8f0) at /kde/src/kio/src/widgets/pastejob.cpp:62
    #11 0x00007ffff7a5ba43 in KIO::PasteJob::qt_static_metacall (_o=<optimized out>, _c=<optimized out>, _id=<optimized out>, _a=<optimized out>) at /kde/src/kio/src/widgets/pastejob.h:66
    #12 0x00007ffff5b4dada in QObject::event(QEvent*) () from /usr/lib/libQt5Core.so.5
    #13 0x00007ffff6665352 in QApplicationPrivate::notify_helper(QObject*, QEvent*) () from /usr/lib/libQt5Widgets.so.5
    #14 0x00007ffff666e829 in QApplication::notify(QObject*, QEvent*) () from /usr/lib/libQt5Widgets.so.5
    #15 0x00007ffff5b204f2 in QCoreApplication::notifyInternal2(QObject*, QEvent*) () from /usr/lib/libQt5Core.so.5
    #16 0x00007ffff5b22d56 in QCoreApplicationPrivate::sendPostedEvents(QObject*, int, QThreadData*) () from /usr/lib/libQt5Core.so.5
    #17 0x00007ffff5b79244 in ?? () from /usr/lib/libQt5Core.so.5
    #18 0x00007ffff3cd46be in g_main_context_dispatch () from /usr/lib/libglib-2.0.so.0
    #19 0x00007ffff3cd6531 in ?? () from /usr/lib/libglib-2.0.so.0
    #20 0x00007ffff3cd6571 in g_main_context_iteration () from /usr/lib/libglib-2.0.so.0
    #21 0x00007ffff5b78890 in QEventDispatcherGlib::processEvents(QFlags<QEventLoop::ProcessEventsFlag>) () from /usr/lib/libQt5Core.so.5
    #22 0x00007ffff5b1f05c in QEventLoop::exec(QFlags<QEventLoop::ProcessEventsFlag>) () from /usr/lib/libQt5Core.so.5
    #23 0x00007ffff5b27066 in QCoreApplication::exec() () from /usr/lib/libQt5Core.so.5
    #24 0x00007ffff7f1aa39 in kdemain (argc=<optimized out>, argv=<optimized out>) at /kde/src/dolphin/src/main.cpp:189
    #25 0x00007ffff5391023 in __libc_start_main () from /usr/lib/libc.so.6
    #26 0x000055555555507e in _start ()

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D29006

To: aprcela, #dolphin, elvisangelaccio, ngraham, meven
Cc: meven, kfm-devel, azyx, nikolaik, pberestov, iasensio, aprcela, fprice, fbampaloukas, alexde, Codezela, feverfew, spoorun, navarromorales, firef, ngraham, andrebarros, emmanuelp, rdieter, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20200424/2ad8bd60/attachment.htm>