D29119: Dolphin: Implement package kit for deb/rpm service packages

[Méven Car]

meven added inline comments.

INLINE COMMENTS

> servicemenuinstaller.cpp:68
> +                        fail(i18n("Failed to install \"%1\", exited with status \"%2\"",
> +                                  QFileInfo(fileName).fileName(), QVariant::fromValue(status).toString()));
> +                    });

Not sure calling QFileInfo on fileName is necessary : it adds a stat, if fileName does not exist anymore it will break.
Plus we want to display the full absolute fileName (which fileName contains) to allow the user to debug the issue, by himself.
Since once we reach here we can't do anything.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D29119

To: alex, #dolphin, ngraham, elvisangelaccio, meven
Cc: meven, kfm-devel, azyx, nikolaik, pberestov, iasensio, aprcela, fprice, fbampaloukas, alexde, Codezela, feverfew, spoorun, navarromorales, firef, ngraham, andrebarros, emmanuelp, rdieter, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20200424/09fe1429/attachment.htm>